Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial rhobs utilization dashboard with query front end row #528

Merged
merged 10 commits into from
Jun 27, 2023

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros
Copy link
Contributor Author

staging dashboard - https://grafana.stage.devshift.net/d/G1nb8JX4z/rhobs-instance-utilization-overview?orgId=1&refresh=10s&var-datasource=telemeter-prod-01-prometheus&var-namespace=observatorium-metrics-production&var-interval=5m

Ive given the grid positions for the panels such a way that there are 4 panels per row, but when I copy paste the generated JSON the panels gets stacked on one line.

Copy link
Member

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the link to the query frontend dashboard, no? Do you plan to add it in a follow up PR?

Copy link
Member

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imported the changed dashboard into our staging environment and noticed a problem with the memory used widget.

The layout also looks off. Seems like charts are crammed into a very small space. Can you please give them more space so that they look better? It's okay to have more than 1 row/line of widgets.

@coleenquadros
Copy link
Contributor Author

I imported the changed dashboard into our staging environment and noticed a problem with the memory used widget.

The layout also looks off. Seems like charts are crammed into a very small space. Can you please give them more space so that they look better? It's okay to have more than 1 row/line of widgets.

Thats where I provided the grid positions in the panels to allow the panels to be split as 4 panels in one line. But when I copy the JSON it gets moved to one line

@douglascamata
Copy link
Member

@coleenquadros okay. Let's see how they'll look when they are loaded by our automation. I don't mind a fix for the layout in follow up PRs. 👍

Copy link
Member

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final set of changes and I think we can merge this. It's looking pretty good! :D

Copy link
Member

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM :shipit:

@coleenquadros coleenquadros merged commit 2c7db49 into rhobs:main Jun 27, 2023
1 check passed
@coleenquadros coleenquadros deleted the query_frontend branch June 28, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants