-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial rhobs utilization dashboard with query front end row #528
Conversation
Ive given the grid positions for the panels such a way that there are 4 panels per row, but when I copy paste the generated JSON the panels gets stacked on one line. |
observability/dashboards/rhobs-instance-utilization-overview.libsonnet
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the link to the query frontend dashboard, no? Do you plan to add it in a follow up PR?
observability/dashboards/rhobs-instance-utilization-overview.libsonnet
Outdated
Show resolved
Hide resolved
observability/dashboards/rhobs-instance-utilization-overview.libsonnet
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imported the changed dashboard into our staging environment and noticed a problem with the memory used widget.
The layout also looks off. Seems like charts are crammed into a very small space. Can you please give them more space so that they look better? It's okay to have more than 1 row/line of widgets.
observability/dashboards/rhobs-instance-utilization-overview.libsonnet
Outdated
Show resolved
Hide resolved
Thats where I provided the grid positions in the panels to allow the panels to be split as 4 panels in one line. But when I copy the JSON it gets moved to one line |
@coleenquadros okay. Let's see how they'll look when they are loaded by our automation. I don't mind a fix for the layout in follow up PRs. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final set of changes and I think we can merge this. It's looking pretty good! :D
observability/dashboards/rhobs-instance-utilization-overview.libsonnet
Outdated
Show resolved
Hide resolved
observability/dashboards/rhobs-instance-utilization-overview.libsonnet
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM
https://issues.redhat.com/browse/RHOBS-704