Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus rolebinding #68

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Add prometheus rolebinding #68

merged 3 commits into from
Aug 30, 2024

Conversation

xiormeesh
Copy link
Contributor

As discussed on Slack, one step was missing: we need to add Role and RoleBinding for prometheus-k8s to get endpoints in monitored namespace

simonpasquier
simonpasquier approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit 565c226 into rhobs:main Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiormeesh @simonpasquier