Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: support non-VERSION approach for KSM #90

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jul 23, 2024

KSM dropped the VERSION file to reconcile with the structure in other sub-projects (such as the metrics-server) in the latest release. This patch addresses syncbot failing due to its absence.


Blocked-by: #92

@rexagod rexagod requested a review from a team as a code owner July 23, 2024 09:21
@rexagod rexagod force-pushed the ksm-no-version branch 2 times, most recently from f05d45e to e1af28c Compare July 23, 2024 14:20
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Member Author

rexagod commented Jul 23, 2024

Actionlint's throwing false positives: https://github.com/rhobs/syncbot/pull/85/files, should we drop it?

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonpasquier simonpasquier merged commit aadf1d4 into rhobs:main Jul 30, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants