-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI with CMake #1
base: cmake_build2
Are you sure you want to change the base?
Conversation
can you sync with master so that only relavant changes are shown, then i can merge it |
No need to support CMake on an older Ubuntu. (Although certainly resolvable.)
The CMake build fails with:
But the other builds run fine and that was the whole point of this PR - to bring the tests from master here and to add CMake build with tests to CI. Both are done, so I suggest to merge this to your branch now and to continue in OSGeo#348. As for merging, I suggest Rebase and merge here to have the individual commits for review if needed, but I have no strong opinion on that (we'll Squash and merge in the main repo anyway). |
@rkanavath I'm opening this as a PR against the branch in your repo. I did a rebase to the latest master, so there is a lot of changes comparing to your branch. If you rebase to master and force push to yours, this will show a proper diff. I can also force push to your branch if you are fine with that. Please, let me know.
This adds CI, but does not change any code. It is basically what was here, but now it is natively part of the code and will be visible in the PR.
You don't have GitHub Actions enabled, but you can see the tests running in my fork. Like before, the build runs, but grass executable (grass79, grass.py, ...) is not in the right place, so tests fail.