Swiftify interface #103
Merged
Swiftify interface #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh awesome! I tried to do this myself in the past and got stuck due to not know about about Can you verify that these changes don't break the # XMPPFramework with Swift extensions
pod 'XMPPFramework/Swift', :git => 'https://github.com/robbiehanson/XMPPFramework.git', :branch => 'master'
pod 'KissXML', :git => 'https://github.com/MacPass/KissXML.git', :branch => 'swiftless' |
|
I just build XMPPFramework with the proposed KissXML version and the build succeeds. I have no idea if any runtime stuff is broken though. |
|
Both macOS and iOS? |
|
Yup. Both builds succeeded. I didn't see any unit test, are there any to ensure the functionality is actually correct? |
|
There are unit tests in the |
chrisballinger
approved these changes
Jun 3, 2018
This was referenced Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to remove the need of a dedicated Swift source file to make KissXML pure Obj-C again. Please consider this PR with caution as I am no Swift expert. The tests for iOS run fine, macOS test did crash in NSXml under Xcode 9.2 and macOS 10.12 for unknown reasons.