Revise SIMD traits to make working with masks more ergonomic/efficient #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `SimdMask` trait for common operations on SIMD masks, eg. bitwise AND and OR. - Make an assumption that the SIMD mask type is always the same for a particular architecture and lane size. eg. Assume that i32xN and f32xN will use the same mask type. This avoids the need for casting masks. - Add `SimdVal` base trait which can house associated types and methods that are common to all SIMD vectors, regardless of element type. Initially this just defines the associated mask type, but in future it could also provide operations such as loading and storing values, and bitwise operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SimdMasktrait for common operations on SIMD masks, eg. bitwise AND and OR.Make an assumption that the SIMD mask type is always the same for a particular architecture and lane size. eg. Assume that i32xN and f32xN will use the same mask type. This avoids the need for casting masks.
Add
SimdValbase trait which can house associated types and methods that are common to all SIMD vectors, regardless of element type.Initially this just defines the associated mask type, but in future it could also provide operations such as loading and storing values, and bitwise operations.