Add missing checks for length match in reshaping methods #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `TensorBase` to call `MutLayout::reshaped` to ensure the new shape is checked for compatibility with the existing layout length and contiguous-ness. - Change reshaping methods in `layout.rs` to return results, as these are more convenient to work with in tests. - Remove unused mutating `Layout::reshape` methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to check the requirements for length match or contiguity when reshaping
is a sure fire way to cause OOB reads.
Change
TensorBaseto callMutLayout::reshapedto ensure the newshape is checked for compatibility with the existing layout length
and contiguous-ness.
Change reshaping methods in
layout.rsto return results, as theseare more convenient to work with in tests.
Remove unused mutating
Layout::reshapemethods