Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a change similar to 2f0327c by combining the separate matrix multiplications for the 3 gates into a single matmul. This reduces the total number of matmuls from
num_directions * seq_length * 6
tonum_directions * seq_length * 2
.Using only two matmuls is only possible when
linear_before_reset=true
, as is the case all models I have worked with so far, since it is what PyTorch and cuDNN support and what TensorFlow uses by default. With the GRU formulation in the original paper, an additional matmul is required since the reset gate has to be computed before thehidden_state @ hidden_weights[hidden_gate]
matmul can be done.Fixes #85
TODO: