Re-implement Where operator fallback
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implement the slow path in `Where` for inputs that are not compatible with the "fast broadcast" path. The implementation follows the same pattern as for the fallback in binary operators.
Usage of `broadcast_iter` has been replaced by faster code patterns in binary, ternary and variadic operators implementations. Code needing to broadcast for other reasons can use `TensorBase::broadcast` instead. Fixes #189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement the slow path in the
Whereoperator to use a code pattern similar to that added for binary ops in #190.This replaces the last usage of the
TensorBase::broadcast_itermethod, so that code has been removed from rten-tensor. Any code outside the rten crates needing to broadcast tensors should be migrated toTensorBase::broadcast.Fixes #189