Make TensorBase::{inner_iter, inner_iter_mut} more efficient
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
inner-iter-opt
branch
from
ab2c662
to
cae212f
Compare
The slicing in each call to `next` was slow. Since these iterators yield views with the same layout each time, we can precompute the layout when the iterator is constructed. Each call to `next` then just has to compute the storage offset for the next view. This optimization is not yet implemented for `inner_iter_dyn`, but could be in future.
robertknight
force-pushed
the
inner-iter-opt
branch
from
cae212f
to
8be0513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slicing in each call to
nextwas slow. Since these iterators yield views with the same layout each time, we can precompute the layout when the iterator is constructed. Each call tonextthen just has to compute the storage offset for the next view.This optimization is not yet implemented for
inner_iter_dyn, but in principle it could be.TODO:
TensorBase::from_storage_and_layout, when the storage is mutable, or change the API