Support using matmul for Einsum equations with 3 or more inputs #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
einsum-faster-many-input
branch
2 times, most recently
from
8b6e0c9
to
3c5c3b8
Compare
Previously Einsum equations with more than two inputs were handled via a fallback to a naive implementation that was much less efficient than a matmul if a reduction was required. In this commit, equations are split into a path where each step handles one or two inputs. Each step will use matmul, multiply or reduce-sum as appropriate. The generated path always processes inputs in left-to-right order. This can be much less efficient than the optimal contraction order. Using a better algorithm is left as a future exercise.
robertknight
force-pushed
the
einsum-faster-many-input
branch
from
3c5c3b8
to
5da3c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Einsum equations with more than two inputs were handled via a fallback to a naive implementation that was much less efficient than a matmul if a reduction was required. In this commit, equations are split into a path where each step handles one or two inputs. Each step will use matmul, multiply or reduce-sum as appropriate.
The generated path always processes inputs in left-to-right order. This can be much less efficient than the optimal contraction order. Using a better algorithm is left as a future exercise.
Part of #298.