Implement If operator
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2024
Merged
robertknight
force-pushed
the
if-operator
branch
8 times, most recently
from
82141a2
to
496f0e3
Compare
Add infrastructure to support control flow operators which execute subgraphs and use it to implement the `If` operator. The implementation of control flow operators follows ONNX by supporting graphs as operator attributes. These graphs may refer to (_capture_) values from the parent graph at runtime, like a closure. The `If` operator has two subgraphs which take no inputs but instead use captures to access values from the parent graph. Operator inputs in RTen are represented as a list of graph-local node IDs rather than names. Therefore an operator's input list cannot directly refer to captured values by name. Instead when an operator input is encountered that is a capture, a value node is created in the subgraph to represent it and the ID of that value node is added to a list of `captures` for the graph. At runtime when resolving the value of a node it is first looked up by ID in inputs and locals for the current graph and if that fails, a lookup by name is performed in the capture environment. - Add `If` operator to RTen model schema - Support deserializing operators with attribute values that are graphs - Extend `Operator` trait with a `run_subgraph` method that is like `run` but takes a capture environment as an extra argument and returns a `RunError` instead of an `OpError`. - Implement `If` operator that uses `run_subgraph` - Support running operators with subgraphs in `Graph::run_plan`
robertknight
force-pushed
the
if-operator
branch
from
496f0e3
to
beb4ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the If operator. This is the first control flow operator that is being supported in RTen, so most of the changes are the infrastructure needed to support operators which run subgraphs as part of their execution.
TODO:
Ifoperator deserializationCaptureEnv::get_inputto avoid using a local value node if it is a captureGraphobject in anIfAttrsTDeferred to subsequent PRs
encoder_hidden_statesinput in TrOCR (see Add TrOCR example #304).