Optimize node ID hashing, DynLayout construction
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `product` iterator call from the loop which calculates strides, with a reversed loop which calculates the strides incrementally. Previously this call accounted for ~1% of the main-thread time in a Whisper benchmark, now it is about 0.2%.
This provides hashing at the expense of not being DOS-resistant. That's OK in this context because the keys are all `NodeId`s, which we control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of small optimizations for graph executions with many operations relative to compute. These were found by profiling main-thread execution time of the whisper-rs demo.