Make Message a pure data struct with exported members #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relegating "Message" related code entirely to core where it belongs
…avor of exported data members
roberto-bayardo
force-pushed
the
message-cleanup-2
branch
from
d7ad900
to
28a6e50
Compare
roberto-bayardo
force-pushed
the
message-cleanup
branch
from
8b7b8ab
to
e768c7d
Compare
roberto-bayardo
force-pushed
the
message-cleanup
branch
2 times, most recently
from
6418bf1
to
484da8f
Compare
roberto-bayardo
force-pushed
the
message-cleanup
branch
from
484da8f
to
43c1726
Compare
roberto-bayardo
force-pushed
the
message-cleanup
branch
from
43c1726
to
c5c1873
Compare
roberto-bayardo
force-pushed
the
message-cleanup
branch
from
c5c1873
to
0ea905b
Compare
roberto-bayardo
force-pushed
the
message-cleanup
branch
2 times, most recently
from
dec2d8e
to
57d1e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR with no functional changes. It changes Message to a data-only struct with exported members, removing the field accessor methods and the error-prone NewMessage factory method. This change also removes the inconsistent & unnecessary copying of message data references from st.msg to the state transition struct.