Add ROC_BASIC_WEBSERVER_HOST and ROC_BASIC_WEBSERVER_PORT variables #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gauteab
changed the title
Anton-4
approved these changes
Dec 13, 2023
joprice
added a commit
to joprice/basic-webserver
that referenced
this pull request
May 16, 2024
The pr roc-lang#15 exposed host and port as env vars, but left the println hardcoded to 'localhost'. This can be misleading since it makes it seem that the host env var is not taking effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to set the host name and port of the server via environment variables.
Solves #14