Refactor host files into crates #54
Conversation
lukewilliamboswell
force-pushed
the
refactor-host
branch
from
f10a1eb
to
f276fd1
Compare
lukewilliamboswell
force-pushed
the
refactor-host
branch
from
8420a46
to
4a4ef69
Compare
There was a problem hiding this comment.
Looks good! We may want to wait on merging for @Anton-4 to finish the roc-lang/roc#6873 investigation that is blocking the sister PR for basic-cli here: roc-lang/basic-cli#194
|
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
Let's do formatting changes in a separate PR in the future.
| fn inc(&mut self) { | ||
| unimplemented!(); | ||
| } | ||
| fn dec(&mut self) { | ||
| unimplemented!(); | ||
| } | ||
| fn is_refcounted() -> bool { | ||
| true | ||
| } |
There was a problem hiding this comment.
Only matters if a list containing said type is passed between host and roc.
So if there are no effects of the sort List (Result Stream StremErr), doesn't matter.
Same witht he other case pointed out.
| impl roc_std::RocRefcounted for ReadResult { | ||
| fn inc(&mut self) { | ||
| unimplemented!(); | ||
| } | ||
| fn dec(&mut self) { | ||
| unimplemented!(); | ||
| } | ||
| fn is_refcounted() -> bool { | ||
| true | ||
| } | ||
| } |
There was a problem hiding this comment.
This was also generated by RustGlue.roc. I think we could remove it if we wanted to, because it's not used or needed. I think the implementation is just to satisfy the trait requirement.
There was a problem hiding this comment.
Thanks, I'll try to remove them all
|
Looks like some of these are used... |
Oh, I know whats happening. They type is being used in a RocResult. Which does use the refcounting impl. But still, the actual impl won't be called unless eventually the type is used in a list. |
|
So they are unused, but referenced by RocResult. So they can't be deleted. |
This reverts commit 3e35d57.
| @@ -0,0 +1,18 @@ | |||
| TODO other crates | |||
There was a problem hiding this comment.
I just want to have this handled before we merge. I can probably get to it tomorrow but anyone is welcome to take it.
There was a problem hiding this comment.
I can probably get to it tomorrow
I got deep down a segfault rabbit hole when updating the examples to basic-cli 0.13 :p
There was a problem hiding this comment.
@lukewilliamboswell Can you explain what the purpose is of the roc_app and roc_fn crates and why we don't need those in basic-cli?
This PR separates the rust host files from the roc platform files, and adds a
build.rocscript.The purpose of this change is to simplify the build process, and to have a clearer separation between these elements as this repository serves as an example of roc platforms.