Do not exit the repl when Ctrl-C is pressed, fixes #6870 #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ageron
force-pushed
the
ignore-ctrl-c-in-repl
branch
from
4538e0c
to
4c43d54
Compare
|
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
ageron
force-pushed
the
ignore-ctrl-c-in-repl
branch
from
4c43d54
to
46a5906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl-C currently exits the REPL. In virtually every other REPL, Ctrl-C just cancels the current command, it doesn't exit. This means that users will accidently close their ROC REPL and lose their current work. It's also convenient to be able to cancel the current command very simply (without having to type Ctrl-A + Ctrl-K).
See the discussion in #6870.