Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ThreadSafeRefcountedResourceHeap as a new crate on roc #7059

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Add ThreadSafeRefcountedResourceHeap as a new crate on roc #7059

merged 7 commits into from
Sep 19, 2024
+309 −3

Conversation

lukewilliamboswell
Copy link
Collaborator

No description provided.

@lukewilliamboswell
Copy link
Collaborator Author

@bhansconnect there are a few things clip isn't happy with -- I've looked at these, but I don't trust myself enough to fix these.

$ cargo clippy -p roc_std_heap
warning: `roc_std_heap` (lib) generated 14 warnings

bhansconnect
bhansconnect previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@bhansconnect bhansconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be all good now. Also merged in changes from basic-webserver.

bhansconnect
bhansconnect previously approved these changes Sep 17, 2024
View reviewed changes
@lukewilliamboswell lukewilliamboswell merged commit 821c84f into main Sep 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhansconnect bhansconnect bhansconnect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewilliamboswell @bhansconnect