Allow responding with named MessagePack data. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I did not notice there were two repos - should I have sent this to SergioBenitez/Rocket instead? |
|
Closing since I seem to have used the wrong repo. Feel free to reopen if I am mistaken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rwf2#2107. See also rwf2#1882.
This implementation does not change the default, but notes in the docs that users should pick an explicit option to allow for the default changing in the future.
Also, const generics are used to avoid having to duplicate implementations which would be the same for both named and compact representations. Arguably this does not provide the best user ergonomics, so let me know if you'd prefer a different implementation.