Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testscript: tip broke MainStart for fuzzing support #144

Closed
mvdan opened this issue Sep 21, 2021 · 0 comments
Closed

testscript: tip broke MainStart for fuzzing support #144

mvdan opened this issue Sep 21, 2021 · 0 comments

Comments

@mvdan
Copy link
Collaborator

mvdan commented Sep 21, 2021 

# github.com/rogpeppe/go-internal/testscript
go/pkg/mod/github.com/rogpeppe/go-internal@v1.8.1-0.20210531173208-9df06c38c09b/testscript/exe.go:231:8: not enough arguments in call to testing.MainStart

Looks like the merge of dev.fuzz last night added a parameter to MainStart. We should probably use build tags to insert an extra nil parameter on Go 1.18 and later.
mvdan added a commit to mvdan/go-internal that referenced this issue Sep 22, 2021
@mvdan
testscript: add support for Go master aka 1.18
06c74dd 
Fuzzing support brought a new parameter to MainStart,
as well as more methods on testDeps.
Use build tags to support those without breaking 1.16 nor 1.17.

While at it, bump CI to test the two latest Go versions.

Fixes rogpeppe#144.
mvdan added a commit to mvdan/go-internal that referenced this issue Sep 22, 2021
@mvdan
testscript: add support for Go master aka 1.18
2c163ac 
Fuzzing support brought a new parameter to MainStart,
as well as more methods on testDeps.
Use build tags to support those without breaking 1.16 nor 1.17.

While at it, bump CI to test the two latest Go versions.

Fixes rogpeppe#144.
mvdan added a commit to mvdan/go-internal that referenced this issue Sep 22, 2021
@mvdan
testscript: add support for Go master aka 1.18
6f57cb6 
Fuzzing support brought a new parameter to MainStart,
as well as more methods on testDeps.
Use build tags to support those without breaking 1.16 nor 1.17.

While at it, bump CI to test the two latest Go versions.

Finally, run 1.17's gofmt, as CI demands it.

Fixes rogpeppe#144.
mvdan added a commit to mvdan/go-internal that referenced this issue Sep 23, 2021
@mvdan @rogpeppe
testscript: add support for Go master aka 1.18
ffb0322 
Fuzzing support brought a new parameter to MainStart,
as well as more methods on testDeps.
Use build tags to support those without breaking 1.16 nor 1.17.

While at it, bump CI to test the two latest Go versions,
and run 1.17's gofmt, as CI demands it.

Finally, make CI also test with Go's master version,
to ensure that we are compatible with it.
We pin a specific commit, since that keeps CI stable.

Fixes rogpeppe#144.

Co-authored-by: Roger Peppe <rogpeppe@gmail.com>
@mvdan mvdan closed this as completed in 86f73c5 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvdan