Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/testscript: support -update flag #121

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Jan 18, 2021

No description provided.

@myitcv myitcv requested a review from mvdan January 18, 2021 12:47
@myitcv myitcv force-pushed the cmd_testscript_update branch 4 times, most recently from 45ea8d3 to 2e06fa4 Compare January 18, 2021 13:34
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! AFAICS there are still a couple of issues the need fixing (or at least test cases adding for them if my assessment is flawed)...

cmd/testscript/help.go Outdated Show resolved Hide resolved
cmd/testscript/help.go Outdated Show resolved Hide resolved
cmd/testscript/main.go Outdated Show resolved Hide resolved
cmd/testscript/main.go Show resolved Hide resolved
cmd/testscript/testdata/update.txt Outdated Show resolved Hide resolved
@myitcv myitcv force-pushed the cmd_testscript_update branch 2 times, most recently from 4e70325 to 47e2b36 Compare January 18, 2021 14:54
@myitcv
Copy link
Collaborator Author

myitcv commented Jan 18, 2021

Thanks for the review, @rogpeppe. All comments addressed, with one small question by way of reply.

Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last thing to do (wouldn't it be nice to have only one copy of the help text?), thanks!

cmd/testscript/help.go Show resolved Hide resolved
This is exactly equivalent to setting testscript.Params.UpdateScripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants