-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testscript: add build:tag condition #150
Conversation
The |
5f80a78
to
157e235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow review. This LGTM modulo a couple of minor suggestions, and I think it supercedes #149, right? Thanks for proposing it!
23c8489
to
a3987ea
Compare
a3987ea
to
780a119
Compare
Thanks for the review and zero stress about the review time - you're giving the gift of open source so there are no expectations or obligations. I've applied your suggested changes and rebased on the latest |
Anything else needed here? |
Apologies for my delay here :) Two thoughts:
|
Closing in favor of #154. |
As discussed with @mvdan in #149.