cmd/testscript: remove redundant use of Failed #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Jun 10, 2024
The call to `T.Failed` and its associated comment are a legacy of previous implementation. The comment isn't accurate and the call isn't necessary (`FailNow` is always called even when `ContinueOnError` is set). Deprecate the associated `TFailed` type rather than removing it.
rogpeppe
force-pushed
the
046-testscript-no-failed
branch
from
618b560
to
35d8abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
T.Failedand its associated comment are a legacy of previous implementation. The comment isn't accurate and the call isn't necessary (FailNowis always called even whenContinueOnErroris set). Deprecate the associatedTFailedtype rather than removing it.