Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CSV conversion to dodge Serde #152

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Rewrite CSV conversion to dodge Serde #152

merged 2 commits into from
Apr 5, 2019

Conversation

LPGhatguy
Copy link
Contributor

@LPGhatguy LPGhatguy commented Apr 5, 2019

Fixes #145.

After filing a bug on the csv crate (BurntSushi/rust-csv#151) it became pretty clear that there isn't really a way for Serde to losslessly decode the localization format Roblox expects for me.

This PR rewrites the CSV parser to manually trawl each record and map them into structs. I added a new regression test for #145 and made sure all existing tests continued to pass.

@LPGhatguy LPGhatguy merged commit 5d681a7 into master Apr 5, 2019
@LPGhatguy LPGhatguy deleted the redo-csv branch April 5, 2019 01:21
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
* Rewrite CSV conversion to dodge Serde

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant