Do not validate .model.json files with no content/whitespace only #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kampfkarren
reviewed
May 3, 2021
LPGhatguy
requested changes
May 7, 2021
There was a problem hiding this comment.
Thank you for the PR! Left some comments.
We should also add a test for this; you can see how tests are written here. Add a project with an empty .model.json file in it, assert that the tree looks correct, then write to the file with a new, valid .model.json. After the change registers, assert that the new tree looks correct.
This reverts commit 0aef16e.
Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
LPGhatguy
approved these changes
May 14, 2021
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
…jo-rbx#420) * Ignore empty/whitespace-only model.json files * Ignore no return value from model.json files during snapshot * Use str::from_utf8 instead of String::from_utf8 * Revert "Ignore no return value from model.json files during snapshot" This reverts commit 0aef16e. * Add test for empty .model.json files * Change empty .model.json check method Co-authored-by: Lucien Greathouse <me@lpghatguy.com> * Format code with cargo fmt * Use raw string instead Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #415