Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons on connected page #722

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

boatbomber
Copy link
Member

Closes #721, #690, #554.

image

By adding buttons to the connected page, the Rojo UI is more consistent across pages, image outages won't make actions invisible, and ambiguous iconography is not an issue.

@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin size: small impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: needs review This work is mostly done, but just needs work to integrate and merge it. labels Jul 9, 2023
@boatbomber boatbomber requested a review from Dekkonot July 9, 2023 03:34
@boatbomber boatbomber enabled auto-merge (squash) July 9, 2023 03:35
@boatbomber boatbomber merged commit 7154113 into rojo-rbx:master Jul 9, 2023
9 checks passed
@boatbomber boatbomber deleted the connected-page-buttons branch July 9, 2023 04:26
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small status: needs review This work is mostly done, but just needs work to integrate and merge it. type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connected page can't access Settings page without disconnecting first
2 participants