Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for spritesheet padding #11

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Add config for spritesheet padding #11

merged 7 commits into from
Jan 8, 2024

Conversation

boatbomber
Copy link
Member

Closes #10.

jeparlefrancais
jeparlefrancais approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@jeparlefrancais jeparlefrancais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

:shipit:

Vorlias
Vorlias approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Vorlias Vorlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if spritesheet_padding_size can just be spritesheet_padding or not, but LGTM and will determine that when I push the release

@boatbomber
Copy link
Member Author

I picked that name to be consistent with max_spritesheet_size conventions, but I'd be fine with either name.

@Vorlias Vorlias merged commit 8b702fe into rojo-rbx:main Jan 8, 2024
2 checks passed
@boatbomber boatbomber deleted the padding-config branch January 18, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vorlias Vorlias Vorlias approved these changes

@jeparlefrancais jeparlefrancais jeparlefrancais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration for spritesheet padding size
3 participants
@boatbomber @Vorlias @jeparlefrancais