Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetIDs method #11

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Add GetIDs method #11

merged 8 commits into from
Oct 5, 2023

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Oct 2, 2023

Overview

GetIDs method return all IDs available at given height. This method combined with Get provides functionality of GetAll, but at the same time is more flexible. Getting contents of all blobs might be the heavy and unnecessary.

Resolves #10

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybal tzdybal requested a review from nashqueue October 2, 2023 12:20
@tzdybal tzdybal added the enhancement New feature or request label Oct 2, 2023
@tzdybal tzdybal requested a review from a team October 2, 2023 12:21
@tzdybal tzdybal added T:enhancement and removed enhancement New feature or request labels Oct 2, 2023
@tzdybal
Copy link
Member Author

tzdybal commented Oct 2, 2023

@MSevey, I have some questions:

  1. for some reason test & lint jobs are not executed - anything missing in the repo?
  2. team mention is not replaced by individual team members in Reviewers - how to fix this?

@tzdybal tzdybal marked this pull request as ready for review October 2, 2023 12:49
@MSevey
Copy link
Contributor

MSevey commented Oct 2, 2023

@MSevey, I have some questions:

  1. for some reason test & lint jobs are not executed - anything missing in the repo?

Error in the workflow file https://github.com/rollkit/go-da/actions/runs/6379741787
we don't have proto in this repo?

@MSevey
Copy link
Contributor

MSevey commented Oct 2, 2023

team mention is not replaced by individual team members in Reviewers - how to fix this?

It looks like you manually requested the review? If so, then it doesn't automatically assign someone.
The automatic review assignment comes from the housekeeping workflow which runs when you open the PR. That will pick 3 reviewers for the PR from the team.

It looks like the auto review request hit some ignore case: https://github.com/rollkit/go-da/actions/runs/6379741784/job/17313941628?pr=11#step:2:8

Did you initially open the PR as a draft? There might be an edge case with ignoring drafts but only running the workflow on open PRs.

MSevey
MSevey previously approved these changes Oct 2, 2023
Copy link
Contributor

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit.

da_test.go Outdated Show resolved Hide resolved
@tzdybal tzdybal requested a review from MSevey October 3, 2023 08:16
@codecov
Copy link

codecov bot commented Oct 3, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@tzdybal tzdybal enabled auto-merge (squash) October 3, 2023 08:38
@tzdybal tzdybal merged commit 76cf1d8 into main Oct 5, 2023
10 checks passed
@tzdybal tzdybal deleted the tzdybal/get_ids branch October 5, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: GetAll method
3 participants