fix(dsv): fix type of processRow option (#1581)

* fix(typescript): fix sourcemap sourcecontent referencing non-existent files (#1571) * test(typescript): add test case for incorrect `sourceContent` * fix(typescript): fix .js.map files being treated as declarations * fix(dsv): type of processRow * test(dsv): update test for processRow types --------- Co-authored-by: Ian Yong <ianyongyc@gmail.com>
rollup · Sep 25, 2023 · 09bab88 · 09bab88
1 parent fb2a2ae
commit 09bab88
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/dsv/test/types.ts b/packages/dsv/test/types.ts
@@ -13,7 +13,17 @@ const config: RollupOptions = {
       include: 'node_modules/**',
       exclude: ['node_modules/foo/**', 'node_modules/bar/**'],
       processRow(row) {
-        return row;
+        return {
+          foo: +row.foo,
+          bar: new Date(row.bar),
+          baz: row.baz === 'true',
+          ...row
+        };
+      }
+    }),
+    dsv({
+      processRow() {
+        // void
       }
     })
   ]

diff --git a/packages/dsv/types/index.d.ts b/packages/dsv/types/index.d.ts
@@ -20,7 +20,7 @@ interface RollupDsvOptions {
    * The function can either manipulate the passed row, or return an entirely new row object.
    * @default undefined
    */
-  processRow?: null | ((row: DSVRowString, id: string) => DSVRowString | undefined);
+  processRow?: null | ((row: DSVRowString, id: string) => object | void);
 }
 
 /**