Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commonjs): preserve this reference in the child class #1537

Merged
merged 4 commits into from
Jul 15, 2023
Merged

fix(commonjs): preserve this reference in the child class #1537

merged 4 commits into from
Jul 15, 2023

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jul 13, 2023 •
edited
Loading

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves rollup/rollup#5062

Description

using Reflect.construct function to create an instance in the getAugmentedNamespace function for preserving this reference in the child class.

@robertsLando robertsLando mentioned this pull request Jul 13, 2023
Closed
TrickyPi and others added 2 commits July 14, 2023 15:21
@TrickyPi @dasa
tweak
161dbcf 
Co-authored-by: Dasa Paddock <dpaddock@esri.com>
@TrickyPi
test: update snapshots
85741f8
lukastaegert
lukastaegert approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great work!

@shellscape shellscape merged commit ee4feb2 into rollup:master Jul 15, 2023
7 checks passed
@TrickyPi TrickyPi deleted the fix/rollup-5062 branch July 18, 2023 03:29
@TrickyPi TrickyPi mentioned this pull request Jul 23, 2023
Merged
9 tasks
@bluwy bluwy mentioned this pull request Oct 29, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasa dasa dasa left review comments

@lukastaegert lukastaegert lukastaegert approved these changes

@shellscape shellscape Awaiting requested review from shellscape shellscape is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class this is set to super() instance
4 participants
@TrickyPi @dasa @lukastaegert @shellscape