Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commonjs,dynamic-import-vars,inject,replace,strip,esm-shim): update magic-string #1608

Closed
wants to merge 2 commits into from

Conversation

Dunqing
Copy link

@Dunqing Dunqing commented Oct 12, 2023

Rollup Plugin Name: commonjs,dynamic-import-vars,inject,replace,strip,esm-shim

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

The current version of magic-string doesn't handle sources and sourcesContent correctly, so vite can't handle sourcemap correctly, the related issue is vitejs/vite#13657. The latest version of magic-string has been fixed, you can see Rich-Harris/magic-string#242

In addition, magic-string has no breaking changes so we can update it with confidence.

@shellscape
Copy link
Collaborator

Hey thanks for the PR. Looks like #1596 already takes care of this thought. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants