Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commonjs): preserve the class body property keys even if they are special keywords #1688

Merged
merged 3 commits into from
May 22, 2024

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Feb 26, 2024

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
resolves #1682

Description

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for fixing!

@Bisstocuz
Copy link

Bisstocuz commented May 20, 2024

@shellscape @lukastaegert @TrickyPi Hello, when to merge this? This issue prevent us from building Discord bot.

#1682 (comment)

@lukastaegert lukastaegert merged commit 0bb872b into rollup:master May 22, 2024
5 checks passed
@TrickyPi TrickyPi deleted the fix/1682 branch May 23, 2024 01:27
younggglcy pushed a commit to younggglcy/plugins that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing fails when a class property is named global
3 participants