Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIScrollView to scroll items if not fit to the screen #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 44 additions & 21 deletions REMenu/REMenu.m
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,15 @@ @interface REMenuItem ()

@interface REMenu ()

@property (strong, readwrite, nonatomic) UIView *menuView;
@property (strong, readwrite, nonatomic) UIScrollView *menuView;
@property (strong, readwrite, nonatomic) UIView *menuWrapperView;
@property (strong, readwrite, nonatomic) REMenuContainerView *containerView;
@property (strong, readwrite, nonatomic) UIView *containerView;
@property (strong, readwrite, nonatomic) UIButton *backgroundButton;
@property (assign, readwrite, nonatomic) BOOL isOpen;
@property (assign, readwrite, nonatomic) BOOL isAnimating;
@property (strong, readwrite, nonatomic) NSMutableArray *itemViews;
@property (weak, readwrite, nonatomic) UINavigationBar *navigationBar;
@property (weak, readwrite, nonatomic) UIView *viewToShowFrom;
@property (strong, readwrite, nonatomic) UIToolbar *toolbar;

@end
Expand Down Expand Up @@ -115,11 +116,13 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view

self.isOpen = YES;
self.isAnimating = YES;


self.viewToShowFrom = view;

// Create views
//
self.containerView = ({
REMenuContainerView *view = [[REMenuContainerView alloc] init];
UIView *view = [[UIView alloc] init];
view.clipsToBounds = YES;
view.autoresizingMask = UIViewAutoresizingFlexibleWidth;

Expand All @@ -129,9 +132,9 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
}
view;
});

self.menuView = ({
UIView *view = [[UIView alloc] init];
UIScrollView *view = [[UIScrollView alloc] init];
if (!self.liveBlur || !REUIKitIsFlatMode()) {
view.backgroundColor = self.backgroundColor;
}
Expand Down Expand Up @@ -183,8 +186,6 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
button;
});

CGFloat navigationBarOffset = self.appearsBehindNavigationBar && self.navigationBar ? 64 : 0;

// Append new item views to REMenuView
//
for (REMenuItem *item in self.items) {
Expand All @@ -195,15 +196,15 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
itemHeight += self.cornerRadius;

UIView *separatorView = [[UIView alloc] initWithFrame:CGRectMake(self.separatorOffset.width,
index * self.itemHeight + index * self.separatorHeight + 40.0 + navigationBarOffset + self.separatorOffset.height,
index * self.itemHeight + index * self.separatorHeight + self.separatorOffset.height,
rect.size.width - self.separatorOffset.width,
self.separatorHeight)];
separatorView.backgroundColor = self.separatorColor;
separatorView.autoresizingMask = UIViewAutoresizingFlexibleWidth;
[self.menuView addSubview:separatorView];

REMenuItemView *itemView = [[REMenuItemView alloc] initWithFrame:CGRectMake(0,
index * self.itemHeight + (index + 1.0) * self.separatorHeight + 40.0 + navigationBarOffset,
index * self.itemHeight + (index + 1.0) * self.separatorHeight,
rect.size.width,
itemHeight)
menu:self item:item
Expand All @@ -218,12 +219,15 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
}
[self.menuView addSubview:itemView];
}

// Set up frames
//
self.menuWrapperView.frame = CGRectMake(0, -self.combinedHeight - navigationBarOffset, rect.size.width, self.combinedHeight + navigationBarOffset);
self.menuView.frame = self.menuWrapperView.bounds;
if (REUIKitIsFlatMode() && self.liveBlur) {
self.menuWrapperView.frame = CGRectMake(0, -self.combinedHeight, self.viewToShowFrom.bounds.size.width, self.combinedHeight);
CGFloat height = MIN(self.viewToShowFrom.bounds.size.height - self.navigationBarOffset, self.combinedHeight);
self.menuView.frame = CGRectMake(0, 0, self.viewToShowFrom.bounds.size.width, height);
self.menuView.contentSize = CGSizeMake(self.viewToShowFrom.bounds.size.width, self.combinedHeight);

if (REUIKitIsFlatMode() && self.liveBlur) {
self.toolbar.frame = self.menuWrapperView.bounds;
}
self.containerView.frame = CGRectMake(rect.origin.x, rect.origin.y, rect.size.width, rect.size.height);
Expand Down Expand Up @@ -252,7 +256,7 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
animations:^{
self.backgroundView.alpha = self.backgroundAlpha;
CGRect frame = self.menuView.frame;
frame.origin.y = -40.0 - self.separatorHeight;
frame.origin.y = self.navigationBarOffset;
self.menuWrapperView.frame = frame;
} completion:^(BOOL finished) {
self.isAnimating = NO;
Expand All @@ -264,7 +268,7 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
animations:^{
self.backgroundView.alpha = self.backgroundAlpha;
CGRect frame = self.menuView.frame;
frame.origin.y = -40.0 - self.separatorHeight;
frame.origin.y = self.navigationBarOffset;
self.menuWrapperView.frame = frame;
} completion:^(BOOL finished) {
self.isAnimating = NO;
Expand All @@ -278,12 +282,31 @@ - (void)showFromRect:(CGRect)rect inView:(UIView *)view
animations:^{
self.backgroundView.alpha = self.backgroundAlpha;
CGRect frame = self.menuView.frame;
frame.origin.y = -40.0 - self.separatorHeight;
frame.origin.y = self.navigationBarOffset;
self.menuWrapperView.frame = frame;
} completion:^(BOOL finished) {
self.isAnimating = NO;
}];
}

[[NSNotificationCenter defaultCenter]
addObserver:self
selector:@selector(updateViewOnRotate:)
name:UIDeviceOrientationDidChangeNotification
object:nil];
}

-(CGFloat) navigationBarOffset {
CGFloat statusBarHeight = MIN([[UIApplication sharedApplication] statusBarFrame].size.width, [[UIApplication sharedApplication] statusBarFrame].size.height);

return self.navigationBar ? self.navigationBar.frame.size.height + statusBarHeight : 0;
}

-(void) updateViewOnRotate:(NSNotification*) notification {
CGFloat height = MIN(self.viewToShowFrom.bounds.size.height - self.navigationBarOffset, self.combinedHeight);
self.menuView.frame = CGRectMake(0, 0, self.viewToShowFrom.bounds.size.width, height);
self.menuView.contentSize = CGSizeMake(self.viewToShowFrom.bounds.size.width, self.combinedHeight);
self.menuWrapperView.frame = CGRectMake(0, self.navigationBarOffset, self.viewToShowFrom.bounds.size.width, height);
}

- (void)showInView:(UIView *)view
Expand All @@ -299,8 +322,6 @@ - (void)showFromNavigationController:(UINavigationController *)navigationControl

self.navigationBar = navigationController.navigationBar;
[self showFromRect:CGRectMake(0, 0, navigationController.navigationBar.frame.size.width, navigationController.view.frame.size.height) inView:navigationController.view];
self.containerView.appearsBehindNavigationBar = self.appearsBehindNavigationBar;
self.containerView.navigationBar = navigationController.navigationBar;
if (self.appearsBehindNavigationBar) {
[navigationController.view bringSubviewToFront:navigationController.navigationBar];
}
Expand All @@ -311,7 +332,9 @@ - (void)closeWithCompletion:(void (^)(void))completion
if (self.isAnimating) return;

self.isAnimating = YES;


[[NSNotificationCenter defaultCenter] removeObserver:self];

CGFloat navigationBarOffset = self.appearsBehindNavigationBar && self.navigationBar ? 64 : 0;

void (^closeMenu)(void) = ^{
Expand Down Expand Up @@ -368,7 +391,7 @@ - (void)close

- (CGFloat)combinedHeight
{
return self.items.count * self.itemHeight + self.items.count * self.separatorHeight + 40.0 + self.cornerRadius;
return self.items.count * self.itemHeight + self.items.count * self.separatorHeight + self.cornerRadius;
}

- (void)setNeedsLayout
Expand Down
33 changes: 0 additions & 33 deletions REMenu/REMenuContainerView.h

This file was deleted.

51 changes: 0 additions & 51 deletions REMenu/REMenuContainerView.m

This file was deleted.