fix(rome_js_formatter): new expression attribute

rome · Nov 12, 2022 · 608d973 · 608d973
1 parent 8ff11fc
commit 608d973
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 6 deletions.
diff --git a/crates/rome_js_formatter/src/jsx/attribute/expression_attribute_value.rs b/crates/rome_js_formatter/src/jsx/attribute/expression_attribute_value.rs
@@ -89,7 +89,6 @@ pub(crate) fn should_inline_jsx_expression(
         | JsObjectExpression(_)
         | JsArrowFunctionExpression(_)
         | JsCallExpression(_)
-        | JsNewExpression(_)
         | JsImportCallExpression(_)
         | ImportMeta(_)
         | JsFunctionExpression(_)

diff --git a/crates/rome_js_formatter/src/lib.rs b/crates/rome_js_formatter/src/lib.rs
@@ -787,11 +787,11 @@ function() {
     // use this test check if your snippet prints as you wish, without using a snapshot
     fn quick_test() {
         let src = r#"
-const a = [
-	longlonglonglongItem1longlonglonglongItem1,
-	longlonglonglongItem1longlonglonglongItem2,
-	longlonglonglongItem1longlonglonglongItem3,
-];
+    <OtherComponent
+      value={
+        new Set(veryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzz)
+      }
+    />
 
 "#;
         let syntax = SourceType::tsx();

diff --git a/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx b/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx
@@ -68,3 +68,9 @@ const a = <Popconfirm
 		<span>Delete</span>
 	</Popconfirm>
 ;
+
+<OtherComponent
+	value={
+		new Set(veryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzz)
+	}
+/>
diff --git a/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap b/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap
@@ -77,6 +77,12 @@ const a = <Popconfirm
 	</Popconfirm>
 ;
 
+<OtherComponent
+	value={
+		new Set(veryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzz)
+	}
+/>
+
 ```
 
 
@@ -176,6 +182,14 @@ const a = (
 	</Popconfirm>
 );
 
+<OtherComponent
+	value={
+		new Set(
+			veryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzz,
+		)
+	}
+/>;
+
 
 ## Unimplemented nodes/tokens
 
@@ -187,6 +201,7 @@ const a = (
 
    10: 			"ui-monospace,SFMono-Regular,SF Mono,Consolas,Liberation Mono,Menlo,monospace",
    30: 			"ui-monospace,SFMono-Regular,SF Mono,Consolas,Liberation Mono,Menlo,monospace",
+   85: 			veryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzz,
 ```