Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Automatically reload rome.json changes #3522

Closed
MichaReiser opened this issue Oct 28, 2022 · 4 comments · Fixed by #3724
Closed

📎 Automatically reload rome.json changes #3522

MichaReiser opened this issue Oct 28, 2022 · 4 comments · Fixed by #3724
Assignees
Labels
E-VScode Editors: VSCode task A task, an action that needs to be performed
Milestone

Comments

@MichaReiser
Copy link
Contributor

Description

Goal

Automatically apply changes made to the rome.json in the VS Code.

Task

  • Listen to changes to the rome.json file in the VS Code extension
  • Send the update configuration command to the LSP on change.,
@MichaReiser MichaReiser added task A task, an action that needs to be performed E-VScode Editors: VSCode labels Oct 28, 2022
@MichaReiser MichaReiser added this to the 10.0.0 milestone Oct 28, 2022
@MichaReiser MichaReiser reopened this Nov 8, 2022
@MichaReiser
Copy link
Contributor Author

I made changes to the rome.json file but the changes aren't picked up in the latest nightly version

@MichaReiser
Copy link
Contributor Author

The "reload" works as expected but the user must close all files for the changes to take effect.

@leops
Copy link
Contributor

leops commented Nov 8, 2022

I imagine that's because we don't push an update to the diagnostics of open documents after the configuration change happens, so the language server needs an incoming event from the editor (re-opening the document might work but theoretically simply editing the content of the file should be enough to trigger a linter pass with the new configuration)

@ematipico
Copy link
Contributor

I wonder if other VSCode extensions like eslint, prettier, deno, etc. suffer from the same "bug". I would exclude prettier because formatting happens via events and there aren't diagnostics. We should check eslint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E-VScode Editors: VSCode task A task, an action that needs to be performed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants