This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_lsp): update all diagnostics after a configuration change #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
MichaReiser
approved these changes
Nov 14, 2022
1 task
This was referenced Dec 6, 2022
This was referenced Dec 7, 2022
1 task
This was referenced Dec 10, 2022
This was referenced Dec 12, 2022
1 task
1 task
1 task
1 task
This was referenced Apr 3, 2023
1 task
This was referenced May 29, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3522
This change forces a diagnostic update on all open documents after a configuration update event
Test Plan
I tested this locally by ensuring that disabling a lint rule in the configuration cause all the corresponding diagnostics to disappear on save