Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Text duplication when using VSCode git utilities #4338

Closed
1 task done
dayblox opened this issue Apr 1, 2023 · 1 comment · Fixed by #4376
Closed
1 task done

🐛 Text duplication when using VSCode git utilities #4338

dayblox opened this issue Apr 1, 2023 · 1 comment · Fixed by #4376
Assignees
Labels
A-LSP Area: language server protocol S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@dayblox
Copy link

dayblox commented Apr 1, 2023

Environment information

⚠ Reproduced only using VSCode extension v0.22.0 (without the CLI installed)

CLI:
  Version:                      12.0.0
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.15.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.1.0"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Running Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i The client isn't connected to any server but rage discovered this running Rome server.

Server:
  Version:                      12.0.0
  Name:                         rome_lsp
  CPU Architecture:             x86_64
  OS:                           windows

Workspace:
  Open Documents:               0

Other Active Server Workspaces:

Workspace:
  Open Documents:               0
  Client Name:                  Visual Studio Code - Insiders
  Client Version:               1.78.0-insider


VSCode
Version: 1.78.0-insider (user setup)
Commit: f31dffc7f9b93a1cdef21243ec30dea7d489a615
Date: 2023-03-31T01:47:17.818Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: Yes

What happened?

index.ts.-.node-ts.-.Visual.Studio.Code.-.Insiders.2023-04-01.15-42-43.mp4
  1. Update file content
  2. Save or not (here without saving)
  3. Revert the change using VSCode built in git utility
  4. Text is duplicated
  5. Save the file
  6. Text is duplicated each time

Only appears to happen the first time a file is opened after a VSCode reload
editor.formatOnSave: true
Does not happen with extension v0.20.0

Expected result

No duplication

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@dayblox dayblox added the S-To triage Status: user report of a possible bug that needs to be triaged label Apr 1, 2023
@ematipico ematipico added S-Bug: confirmed Status: report has been confirmed as a valid bug A-LSP Area: language server protocol and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Apr 7, 2023
@dayblox
Copy link
Author

dayblox commented Apr 13, 2023

Update:
This bugged behaviour was introduced on v0.21.20230324
Cannot replicate on v0.21.20230318

denbezrukov added a commit that referenced this issue Apr 15, 2023
…4376)

fix(vscode): Text duplication when using VSCode git utilities #4338
Conaclos added a commit that referenced this issue Apr 16, 2023
…4376) (#4234)

fix(vscode): Text duplication when using VSCode git utilities #4338

Co-authored-by: Denis Bezrukov <6227442+denbezrukov@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-LSP Area: language server protocol S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants