This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_playground): Unicode Support #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They playground crashed because `btoa` only supports ASCII. This PR ensures that non ASCII characters are propertly encoded before running the code throuh `btoa`.
MichaReiser
commented
Mar 31, 2022
| @@ -22,7 +22,7 @@ jobs: | |||
| node-version: '14' | |||
| - run: npm install --prefix crates/rome_playground | |||
| - uses: jetli/wasm-pack-action@v0.3.0 | |||
| - run: wasm-pack build crates/rome_playground --target web | |||
| - run: wasm-pack build crates/rome_playground --target web --release | |||
There was a problem hiding this comment.
This reduces the wasm size by 0.5 mb
There was a problem hiding this comment.
hum... if we have not done anything to reduce, can this help?
https://rustwasm.github.io/book/reference/code-size.html
MichaReiser
commented
Mar 31, 2022
| @@ -2,7 +2,7 @@ import CodeEditor from "@uiw/react-textarea-code-editor"; | |||
| import "react-tabs/style/react-tabs.css"; | |||
| import init, { run } from "../pkg/rome_playground"; | |||
| import { Tabs, Tab, TabList, TabPanel } from "react-tabs"; | |||
| import {useEffect, useMemo, useState} from "react"; | |||
| import { useEffect, useMemo, useState } from "react"; | |||
There was a problem hiding this comment.
Nit: We should probably move the playground into the website directory. It isn't a proper "rome" rust crate
There was a problem hiding this comment.
It's the same thing that I suggested a while ago.
Deploying with
|
| Latest commit: |
89c4520
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d4d435a.tools-8rn.pages.dev |
xunilrj
approved these changes
Mar 31, 2022
ematipico
approved these changes
Mar 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They playground crashed because
btoaonly supports ASCII.This PR ensures that non ASCII characters are propertly encoded before running the code throuh
btoa.Summary
Test Plan