-
Notifications
You must be signed in to change notification settings - Fork 664
Conversation
Deploying with Cloudflare Pages
|
That is intended. Script snippets don't allow JSX nor Typescript |
Why so? @NicholasLYang can you please add more details to your PR (and title). What bug is this PR fixing? How did you test your change? |
A script can't have JSX because it requires a compilation step. TypeScript can't be loaded as a script because it requires a compilation step. Is there something I am missing? |
The only difference between
The |
If we didn't want script snippets to have TypeScript or JSX, perhaps the better option would be to hide the checkboxes when we're on script mode? Or deactivate them. But I don't see anything wrong with someone trying script + jsx + typescript |
setIsTypeScript(false); | ||
setIsJsx(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this was an oversight of mine. I wanted to apply these two calls when source type changes. Sorry about that
Summary
Fixes bug in playground where changing the typescript checkbox deactivates the jsx one.
Test Plan