This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 664
refactor: Move AST types to rome_rowan
#2372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
MichaReiser
commented
Apr 7, 2022
MichaReiser
force-pushed
the
refactor/move-ast-nodes-to-rowan
branch
from
April 7, 2022 15:20
de245f1
to
1025226
Compare
MichaReiser
changed the title
Refactor/move ast nodes to rowan
refactor: Move AST types to Apr 7, 2022
rome_rowan
ematipico
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change! I will need it for the formatter too :)
ematipico
approved these changes
Apr 8, 2022
ematipico
reviewed
Apr 8, 2022
leops
reviewed
Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR parametrizes the
Ast
traits with aLanguage
type and moves them to therome_rowan
crate so that they can be shared betweenrome_js_syntax
androme_css_syntax
(and potential future crates).Other changes:
Syntax
* aliases toJsSyntax*
andCssSyntax
. For example:type SyntaxNode = rome_rowan::SyntaxNode<JsLanguage>
is now calledJsSyntaxNode
. I believe this helps understanding the difference between the different nodes and aligns the naming with the kind types (that are calledJsSyntaxKind
andCssSyntaxKind
util
methods to theSyntaxNode
struct.cast
totry_cast
and move theSyntaxNodeExt::to
to method toAstNode
with the namecast
.Test Plan
cargo test