This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_parser): Assignment in decorator #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assignments are hard... This PR fixes an issue where an assignment is used inside a decorator, e.g. `@test(--a)` The parser used to panic when rewriting the assignment because any skipped tokens (the case for all tokens inside a decorator) are in the trivia collection and the parser events to ensure all parser methods work correctly. However, this had the effect that `skip_trivia` in `rewrite_parser` moved the offset passed all skipped tokens, passed any not yet processed token (that ultimately get skipped). This PR makes the rewrite parser aware of skipped tokens and only consumes them when the corresponding token gets bumped.
MichaReiser
force-pushed
the
fix/assignment-in-decorators
branch
from
ba953e3
to
ef5915d
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
ef5915d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7019e41e.tools-8rn.pages.dev |
leops
approved these changes
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments are hard...
This PR fixes an issue where an assignment is used inside a decorator, e.g.
@test(--a)The parser used to panic when rewriting the assignment because any skipped tokens (the case for all tokens inside a decorator) are in the trivia collection and the parser events to ensure all parser methods work correctly.
However, this had the effect that
skip_triviainrewrite_parsermoved the offset passed all skipped tokens, passed any not yet processed token (that ultimately get skipped).This PR makes the rewrite parser aware of skipped tokens and only consumes them when the corresponding token gets bumped.
This prevents the parser from panicking for the following two snipped founds when fuzzing the parser #1945