This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): Insert Space after type for import equals declaration
#2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insert a space after the `type` keyword for import equals declarations.
MichaReiser
changed the title
type for import equals declarationtype for import equals declaration
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
e0e4e71
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://148d1a32.tools-8rn.pages.dev |
ematipico
reviewed
Apr 12, 2022
Comment on lines
-32
to
-41
| import typeA = require("foo"); | ||
| import type A = require("foo"); | ||
| export import type = require("A"); | ||
|
|
||
| import typeA = require("A"); | ||
| import type A = require("A"); | ||
|
|
||
| import typea = require("a"); | ||
| import type a = require("a"); | ||
|
|
||
| export import typeB = require("B"); | ||
| export import type B = require("B"); | ||
|
|
||
| export import typeb = require("b"); |
There was a problem hiding this comment.
@MichaReiser Does this mean that this is valid syntax??
There was a problem hiding this comment.
export import type B = require("B");
This is valid, yes :D I would point you to the spec if there would be any...
There was a problem hiding this comment.
No no, I mean, is this export import typeb = require("b"); valid?
Because this is really strange. Our testing suite makes sure that emitted code is actually valid (it parses again) and it seems that it's not doing so... so, there are two possible explanation:
- the formatter testing suite is not catching this case (it doesn't reparse) [likely]
- the parse doesn't emit any syntax errors [unlikely]
There was a problem hiding this comment.
(yeah valid syntax lol, an unfortunate coincidence lol)
There was a problem hiding this comment.
Yeah, it's valid because typeb is a valid identifier and the type keyword is optional.
leops
approved these changes
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert a space after the
typekeyword for import equals declarations.