Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

chore: Print lines exceeding line widths #2429

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

MichaReiser
Copy link
Contributor

Add a new section to formatter tests that print the lines that exceed the configured max line width.

There are few cases where it's valid that a line exceeds the configured line width, for example, if a single identifier exceeds that length. However, for most cases, it's a formatting error.

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45878 45878 0
Passed 44938 44938 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12391 12391 0
Failed 3866 3866 0
Panics 0 0 0
Coverage 76.22% 76.22% 0.00%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d272ea
Status: ✅  Deploy successful!
Preview URL: https://0a152cef.tools-8rn.pages.dev

View logs

@MichaReiser MichaReiser force-pushed the chore/print-lines-exceeding-line-width branch 2 times, most recently from bc0c635 to 00a610d Compare April 14, 2022 06:12
Add a new section to formatter tests that print the lines that exceed the configured max line width.

There are few cases where it's valid that a line exceeds the configured line width, for example, if a single identifier exceeds that length. However, for most cases, it's a formatting error.
@MichaReiser MichaReiser force-pushed the chore/print-lines-exceeding-line-width branch from 00a610d to acc152d Compare April 14, 2022 06:16
@MichaReiser MichaReiser temporarily deployed to aws April 19, 2022 05:54 Inactive
@github-actions
Copy link

@MichaReiser MichaReiser merged commit 2be3a28 into main Apr 19, 2022
@MichaReiser MichaReiser deleted the chore/print-lines-exceeding-line-width branch April 19, 2022 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants