Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_formatter): Fix stackoverflow on Windows for nested seque… #2469

Merged
merged 1 commit into from
Apr 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 39 additions & 5 deletions crates/rome_js_formatter/src/js/expressions/sequence_expression.rs
Original file line number Diff line number Diff line change
@@ -1,25 +1,59 @@
use crate::formatter_traits::FormatTokenAndNode;
use rome_formatter::concat_elements;

use crate::{
format_elements, space_token, FormatElement, FormatResult, Formatter, ToFormatElement,
};

use rome_js_syntax::JsSequenceExpression;
use rome_js_syntax::JsSequenceExpressionFields;
use rome_js_syntax::{JsSequenceExpression, JsSequenceExpressionFields};
use rome_rowan::AstNode;

impl ToFormatElement for JsSequenceExpression {
fn to_format_element(&self, formatter: &Formatter) -> FormatResult<FormatElement> {
let mut current = self.clone();

// Find the left most sequence expression
while let Some(sequence_expression) =
JsSequenceExpression::cast(current.left()?.syntax().clone())
{
current = sequence_expression;
}

// Format the left most sequence expression
let JsSequenceExpressionFields {
left,
comma_token,
right,
} = self.as_fields();
} = current.as_fields();

Ok(format_elements![
let mut formatted = vec![
left.format(formatter)?,
comma_token.format(formatter)?,
space_token(),
right.format(formatter)?,
])
];

// Traverse upwards again and concatenate the sequence expression until we find the first non-sequence expression
while let Some(parent) = current.syntax().parent() {
if let Some(parent_sequence) = JsSequenceExpression::cast(parent) {
let JsSequenceExpressionFields {
left: _left,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
left: _left,
left: _,

we use _ already when we want to ignore a node

comma_token,
right,
} = parent_sequence.as_fields();

formatted.push(format_elements![
comma_token.format(formatter)?,
space_token(),
right.format(formatter)?
]);

current = parent_sequence;
} else {
break;
}
}

Ok(concat_elements(formatted))
}
}