This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_json_syntax): Update JSON AST Facade #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
0d001d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79405fbb.tools-8rn.pages.dev |
ematipico
approved these changes
Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2463 refactored the
Ast*traits to use associated types, but I forgot to re-run the grammar generator after merging the JSON grammar #2466. This PR updates the JSON grammar to use associated types as well and suppresses two unused warnings if a syntax isn't using anyAstNodeLists.