This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_formatter): Remove format_root from Formatter
#2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6c20b1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://580fa2f4.tools-8rn.pages.dev |
This PR removes the `format_root` method from the `Formatter` so that it can be used to format any value implementing `Format`. * Rename existing `format_node` method to `format_sub_tree` * Move `FormatError` and `FormatResult` to `rome_formatter` * Rename `Formatted` to `Printed` * `format_node` to reduce `Formatted` which is the formatted IR that hasn't been printed. Can be printed by calling `print` * `Formatted` replaces `to_format_element` * Introduce new `format` method to format any type implementing `Format`
MichaReiser
force-pushed
the
refactor/format-root
branch
from
ccae17a
to
6c20b1f
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
ematipico
suggested changes
Apr 22, 2022
ematipico
approved these changes
Apr 22, 2022
leops
approved these changes
Apr 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
format_rootmethod from theFormatterso that it can be used to format any value implementingFormat.format_nodemethod toformat_sub_treeFormatErrorandFormatResulttorome_formatterFormattedtoPrintedformat_nodeto reduceFormattedwhich is the formatted IR that hasn't been printed. Can be printed by callingprintFormattedreplacesto_format_elementformatmethod to format any type implementingFormat