This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_formatter): Track token offsets instead of tokens #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1a087ec
|
| Status: | ⚡️ Build in progress... |
ematipico
suggested changes
Apr 22, 2022
There was a problem hiding this comment.
Before we had the message "You tried to print the token '{:?}' twice, and this is not valid" which was somehow descriptive and helped what went wrong.
Now some message are different, which makes sense. Although they don't provide much context sometimes. Would you mind expand this section , explaining how a developer is supposed to do once they find these new messages?
I removed the |
ematipico
approved these changes
Apr 22, 2022
leops
approved these changes
Apr 22, 2022
The `Formatter` tracks all formatted token in debug builds to catch if the same token gets formatted twice or not formatted at all. The current implementation tracks the `JsSyntaxToken`s. The downside of doing this is that a language agnostic implementation needs to track `SyntaxToken<L>` which: * has the consequence that `Formatter` must be generic over `L` * which in turn has the consequence that `Format` must be generic over `L` This PR changes the node tracking to instead only track the absolute offsets of the formatted nodes rather than holding on to the node itself. This removes the need for a generic `Language` parameter and provides the same functionality. ## Test * Commented out the `track_replaced` call in `format_replaced` and verified that some tests now panic with a message that token X wasn't formatted. * Added one an additional `track_replaced` call to `format_replaced` and verified that tests are now failing with a message saying that the token X was formatted twice.
MichaReiser
force-pushed
the
refactor/formatter-token-tracking
branch
from
2736b5a
to
1a087ec
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Formattertracks all formatted tokens in debug builds to catch if the same token gets formatted twice or not formatted at all.The current implementation tracks the
JsSyntaxTokens. The downside of doing this is that a language-agnostic implementation needs to trackSyntaxToken<L>which:Formattermust be generic overLFormatmust be generic overLThis PR changes the node tracking to instead only track the absolute offsets of the formatted nodes rather than holding on to the node itself. This removes the need for a generic
Languageparameter and provides the same functionality.A next step is to move out all
format_functions from theFormatterand put them into standalone functions / extension traits.Test
track_replacedcall informat_replacedand verified that some tests now panic with a message that token X wasn't formatted.track_replacedcall toformat_replacedand verified that tests are now failing with a message saying that the token X was formatted twice.