fix(rome_js_formatter): correctly format sequence expressions

[ematipico]

Summary

This PR fixes #2413

Test Plan

Added three cases that aim to fix them

Metrics

PR
File Based Average Prettier Similarity: 70.87%
Line Based Average Prettier Similarity: 64.93%

main

File Based Average Prettier Similarity: 70.84%
Line Based Average Prettier Similarity: 64.85%

[github-actions]

Parser conformance results on ubuntu-latest

js/262

Test result	main count	This PR count	Difference
Total	45878	45878	0
Passed	44938	44938	0
Failed	940	940	0
Panics	0	0	0
Coverage	97.95%	97.95%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	39	39	0
Passed	36	36	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.31%	92.31%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	588	588	0
Passed	519	519	0
Failed	69	69	0
Panics	0	0	0
Coverage	88.27%	88.27%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	16257	16257	0
Passed	12391	12391	0
Failed	3866	3866	0
Panics	0	0	0
Coverage	76.22%	76.22%	0.00%

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	74888c2
Status:	✅  Deploy successful!
Preview URL:	https://4ccbed25.tools-8rn.pages.dev

View logs

[github-actions]

Playground for commit a55590c

[ematipico]

PR rebased.

[MichaReiser]

The IR of Rome now seems to differ from Prettier.
Prettier

[
  group([
    "____________first",
    ",",
    indent([line, "____________second"]),
    ",",
    indent([line, "____________third"]),
    ",",
    indent([line, "____________third"]),
    ",",
    indent([line, "____________third"]),
    ",",
    indent([line, "____________third"]),
    ",",
    indent([line, "____________third"]),
  ]),
  ";",
  hardline,
]

Rome

List [
    Group(
        List [
            SyntaxTokenSlice("____________first"),
            SyntaxTokenSlice(","),
            Line(Soft),
            Indent(
                List [
                    Line(SoftOrSpace),
                    SyntaxTokenSlice("____________second"),
                    SyntaxTokenSlice(","),
                ],
            ),
            Line(Soft),
            Indent(
                List [
                    Line(SoftOrSpace),
                    SyntaxTokenSlice("____________third"),
                    SyntaxTokenSlice(","),
                ],
            ),
            Line(Soft),
            Indent(
                List [
                    Line(SoftOrSpace),
                    SyntaxTokenSlice("____________third"),
                    SyntaxTokenSlice(","),
                ],
            ),
            Line(Soft),
            Indent(
                List [
                    Line(SoftOrSpace),
                    SyntaxTokenSlice("____________third"),
                    SyntaxTokenSlice(","),
                ],
            ),
            Line(Soft),
            Indent(
                List [
                    Line(SoftOrSpace),
                    SyntaxTokenSlice("____________third"),
                    SyntaxTokenSlice(","),
                ],
            ),
            Line(Soft),
            Indent(
                List [
                    Line(SoftOrSpace),
                    SyntaxTokenSlice("____________third"),
                ],
            ),
        ],
    ),
    StaticToken(";"),
    Line(Hard),
]

Why does Rome need the Line(soft). Seems to be redundant to the SoftOrSpace.

[ematipico]

Thanks @MichaReiser , indeed that soft line break was redundant. I removed it.

[MichaReiser]

Would you mind adding the metrics to the test plan? Looks good.

[ematipico]

Would you mind adding the metrics to the test plan? Looks good.

Added!