You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would help reviewers to add some more context to the PR summary. How does it format empty statements differently than before, in what cases. I otherwise have to open the issue, read through all the discussions or infer the logic from your changes which makes it hard to tell if the logic is working as intended.
ematipico
changed the title
fix(rome_js_formatter): print empty statements differently
fix(rome_js_formatter): empty statements in if/else and do/whileMay 23, 2022
It would help reviewers to add some more context to the PR summary. How does it format empty statements differently than before, in what cases. I otherwise have to open the issue, read through all the discussions or infer the logic from your changes which makes it hard to tell if the logic is working as intended.
I updated the description with a brief example of the changes.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2448
I cherry-picked the implementation of the former PR, which aligns its behaviour to prettier.
The PR changes how
if/else
anddo/while
statements are formatted where the body is an empty statement, by matching Prettier's behaviour:Test Plan
New tests to cover the case