This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Fix(rome_js_formatter):🐛 fix parenthesis expression bad case #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
changed the title
|
I believe this fix is too specific to member expressions. What about computed member assignments? Or any other place where expressions can appear. This is prettier's rule for formatting string literal expressions The way I understand this is that:
This should simplify the logic a bit. |
Addressed that issue. |
IWANABETHATGUY
commented
May 10, 2022
| @@ -3,6 +3,4 @@ nock(/test/) | |||
| [httpMethodNock(method)]('/foo') | |||
| .reply(200, { | |||
| foo: 'bar', | |||
| }); | |||
|
|
|||
| a[("test")] | |||
There was a problem hiding this comment.
I remove this, due to this case has been added in another test file.
|
!bench_formatter |
Formatter Benchmark Results |
MichaReiser
reviewed
May 10, 2022
Comment on lines
105
to
119
| // if expression is a StringLiteralExpression, we could not just return false, here is once case: | ||
| // ```js | ||
| // a[("test")] | ||
| // ``` | ||
| // parent_precedence should be `High` due to the parenthesized_expression's parent is ComputedMemberExpression, | ||
| // and node_precedence should be `Low` due to expression is StringLiteralExpression. | ||
| // the parenthesis should be omitted. | ||
| if parent_precedence > node_precedence | ||
| && !matches!( | ||
| expression, | ||
| JsAnyExpression::JsAnyLiteralExpression( | ||
| JsAnyLiteralExpression::JsStringLiteralExpression(_) | ||
| ) | ||
| ) | ||
| { |
There was a problem hiding this comment.
The easiest is probably to handle StringLiteralExpressions before this line because the precedence isn't relevant for string literals, so there's no point in computing the precedence first.
|
!bench_formatter |
Formatter Benchmark Results |
MichaReiser
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2558
Test Plan
fix the bad case